feat: support passing UID in aggregated apiserver requests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When authorization requests are done through the aggregated apiserver, we need to ensure that the UID comes through the request so it can be used by our IAM system to resolve the user's account within the system.
scotwells
requested review from
JoseSzycho,
OscarLlamas6,
drewr,
ecv and
zachsmith1
JoseSzycho
approved these changes
Dec 24, 2025
ecv
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregated apiserver wasn't configured to accept the user UID value from the milo apiserver. We enabled remote UID passing in datum-cloud/milo#465 so that aggregated apiservers would be able to use the UID value when creating the SubjectAccessReview resource to confirm a user has access to a resource. The UID not being available was causing authorization failures within the IAM system.
I manually deployed this change to the staging environment and confirmed the authorization failures are no longer occurring now that the UID is passed through the request.
Relates to https://github.com/datum-cloud/engineering/issues/90