Fix/vectorstore error message and docstrings #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While reading through
VectorStoreinsrc/classifai/indexers/main.pyI noticed a few small clarity issues:ValueErrorraised for unsupporteddata_typeonly mentioned['csv']and the later error message used{self.data_type}literally (no f-string).This PR cleans those up without changing any functional behaviour.
Changes
Improve the
data_typevalidation message inVectorStore.__init__:csvremains the only supporteddata_type.Fix the error raised in
_create_vector_store_indexfor unsupported file types:Tidy up docstrings and comments in
VectorStoreandfrom_filespace:Rationale
data_type.{self.data_type}being rendered literally in the current error.Testing
Ran: