Add BigQuery reservation configuration#2096
Open
max-ostapenko wants to merge 1 commit intodataform-co:mainfrom
Open
Add BigQuery reservation configuration#2096max-ostapenko wants to merge 1 commit intodataform-co:mainfrom
max-ostapenko wants to merge 1 commit intodataform-co:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for specifying BigQuery reservations at both the project and action level, allowing more granular control over query resource allocation. The changes span CLI flags, project configuration, action builders, and test coverage to ensure correct application and precedence of reservation settings.
BigQuery reservation support:
--default-reservationCLI flag and correspondingdefaultReservationproject config option, enabling users to set a default BigQuery reservation for all actions in a project.IBigQueryExecutionOptionsandBigQueryDbAdapterto accept and propagate areservationparameter, ensuring reservation information is passed through to BigQuery job execution.Action-level reservation configuration:
Assertion,Table,IncrementalTable,Operation,View) to support an optionalbigqueryReservationconfig property, storing it in the action descriptor for runtime precedence over project-level reservations.Test coverage and validation:
Project configuration precedence:
bigqueryReservationoverrides the project-leveldefaultReservationat runtime, with tests confirming the correct behavior.These changes provide users with flexible reservation management for Dataform workload.
Related to #1981