Added apic_m4_l4_db_snapshot_check for CSCwn62369 #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aci-preupgrade-validation-script.py
Outdated
| if not apics: | ||
| return Result(result=ERROR, msg="No controllers found in fabricNode. Is the cluster healthy?", doc_url=doc_url) | ||
|
|
||
| # Check 4: Identify affected APIC models (M4 or L4) |
There was a problem hiding this comment.
2nd check should be apic model as M4/L4. then check version.
why you have separate check for the target version., isn't it should be common for all check ?
Harinadh-Saladi
force-pushed
the
CSCwn62369
branch
from
acb41d6 to
6017e77
Compare
…sult from NA to PASS for not affected versions
Author
|
Resubmitted the code with the changes after discussion with Lovkesh. Have enclosed the validation logs for NA, and MANUAL scenario logs on both M4/L4 ad Non M4/L4 hardware models |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new check for the bug CSCwn62369 and also added the test cases for both pass and fail scenarios.
Have tested in both M4 and L4 hardware devices and got the results as anticipated.
Have enclosed the logs for the same.
CSCwn62369_Test_Logs.txt
CSCwn62369_Pytest_Logs.txt