Relax torch constraint to support PyTorch 2.8+#181
Closed
japadua619 wants to merge 1 commit intodatabricks:mainfrom
Closed
Relax torch constraint to support PyTorch 2.8+#181japadua619 wants to merge 1 commit intodatabricks:mainfrom
japadua619 wants to merge 1 commit intodatabricks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relaxes the torch version constraint from
>=2.7.0,<2.7.1to>=2.7.0,<3.0.0to support PyTorch 2.8, 2.9, and future 2.x releases.Motivation
The current constraint
torch>=2.7.0,<2.7.1is overly restrictive and blocks users from installing megablocks with newer PyTorch 2.x versions, even though the codebase only requirestorch >= 2.0.0(as checked inmegablocks/layers/mlp.py).This change enables compatibility with:
Changes
setup.pyline 65: Changed'torch>=2.7.0,<2.7.1'to'torch>=2.7.0,<3.0.0'Testing
No code changes were made - this is purely a packaging constraint update. The existing codebase already supports torch 2.x versions.
Impact
This unblocks users who need to use megablocks with newer PyTorch versions, particularly for CUDA 12.9 support available in PyTorch 2.9.1.