Skip to content

direct: plan: when action=delete, do not fail deps on read errors #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 2 commits into from
Feb 9, 2026
+8 −5
Merged

direct: plan: when action=delete, do not fail deps on read errors #4462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65aea74
direct: plan: when action=delete, do not fail deps on read errors
denik Feb 6, 2026
7d360cc
update tests
denik Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...ources/permissions/jobs/destroy_without_mgmtperms/with_permissions/out.destroy.direct.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@

>>> errcode as-test-sp [CLI] bundle destroy --auto-approve
Warn: reading resources.jobs.foo.permissions id="/jobs/[NUMID]": [UUID] does not have Manage permissions on Job with ID: ElasticJobId([NUMID]). Please contact the owner or an administrator for access.
Error: cannot plan resources.jobs.foo: dependency failed: resources.jobs.foo.permissions
Warn: reading resources.jobs.foo id="[NUMID]": User [UUID] does not have View or Admin or Manage Run or Owner permissions on job [NUMID]
The following resources will be deleted:
delete resources.jobs.foo

Error: planning failed
All files and directories at the following location will be deleted: /Workspace/Users/[UUID]/.bundle/test-bundle-[UNIQUE_NAME]/default


Exit code: 1
Warn: Ignoring permission error when deleting resources.jobs.foo id=[NUMID]: User [UUID] does not have Admin or Owner permissions on job [NUMID]
Deleting files...
Destroy complete!
2 changes: 1 addition & 1 deletion bundle/direct/bundle_plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func (b *DeploymentBundle) CalculatePlan(ctx context.Context, client *databricks
plan.RemoveEntry(resourceKey)
} else {
log.Warnf(ctx, "reading %s id=%q: %s", resourceKey, dbentry.ID, err)
return false
// This is not an error during deletion, so don't return false here
}
}

Expand Down