Skip to content

Conversation

@dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 10, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Currently, VACUUM TEMPORARY FILES only cleans temporary data generated by spilling, in this PR, it cleans inactive temp table data as well.

Previously, the schema returned by VACUUM TEMPORARY FILES is :

Files: uint64

where the Files column shows the number spill files cleaned.

In this PR, the schema changed to:

spill_files           :   uint64,
temp_table_sessions   :   uint64,

where

  • the spill_files column represents the count of spill files cleaned.
  • the temp_table_sessions column represents the count of inactive sessions for which temporary tables were cleaned.

During execution, the limit specified by the LIMIT <limit> clause is applied sequentially: first to spill files, then to inactive sessions.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 10, 2025
@dantengsky dantengsky marked this pull request as ready for review December 12, 2025 11:34
@dantengsky
Copy link
Member Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant