backport: Merge bitcoin/bitcoin#28136, 27581, 18919, 25634, 25284, 27829#7121
Draft
vijaydasmp wants to merge 4 commits intodashpay:developfrom
Draft
backport: Merge bitcoin/bitcoin#28136, 27581, 18919, 25634, 25284, 27829#7121vijaydasmp wants to merge 4 commits intodashpay:developfrom
vijaydasmp wants to merge 4 commits intodashpay:developfrom
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
vijaydasmp
force-pushed
the
Feb_2026_01
branch
11 times, most recently
from
782715c to
5332bce
Compare
|
This pull request has conflicts, please rebase. |
vijaydasmp
force-pushed
the
Feb_2026_01
branch
from
5332bce to
5549340
Compare
|
This pull request has conflicts, please rebase. |
vijaydasmp
force-pushed
the
Feb_2026_01
branch
from
5549340 to
e48fed1
Compare
vijaydasmp
force-pushed
the
Feb_2026_01
branch
from
e48fed1 to
e7d7e98
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
Feb_2026_01
branch
from
e7d7e98 to
11bb248
Compare
3ea54e5 net: Add continuous ASMap health check logging (Fabian Jahr) 28d7e55 test: Add tests for unfiltered GetAddr usage (Fabian Jahr) b8843d3 fuzz: Let fuzzers use filter options in GetAddr/GetAddresses (Fabian Jahr) e16f420 net: Optionally include terrible addresses in GetAddr results (Fabian Jahr) Pull request description: There are certain statistics we can collect by running all our known clearnet addresses against the ASMap file. This could show issues with a maliciously manipulated file or with an old file that has decayed with time. This is just a proof of concept for now. My idea currently is to run the analysis once per day and print the results to logs if an ASMap file is used. ACKs for top commit: achow101: ACK 3ea54e5 mzumsande: ACK 3ea54e5 brunoerg: crACK 3ea54e5 Tree-SHA512: 777acbfac43cc43ce4a0a3612434e4ddbc65f59ae8ffc9e24f21de09011bccb297f0599cbaa82bcf40ef68e5af582c4e98556379db7ceff7d9f97574a1cf8e09
…,cpp} to rpc/net.cpp bbb68ff refactor: drop protocol.h include header in rpc/util.h (Jon Atack) 1dd62c5 refactor: move GetServicesNames from rpc/util.{h,cpp} to rpc/net.cpp (Jon Atack) Pull request description: Move `GetServicesNames()` from `rpc/util` to `rpc/net.cpp`, as it is only called from that compilation unit and there is no reason for other ones to need it. Remove the `protocol.h` include in `rpc/util.h`, as it was only needed for `GetServicesNames()`, drop an unneeded forward declaration (the other IWYU suggestions would require more extensive changes in other files), and add 3 already-missing include headers in other translation units that are needed to compile without `protocol.h` in `rpc/util.h`, as `protocol.h` includes `netaddress.h`, which in turn includes `util/strencodings.h`. ACKs for top commit: kevkevinpal: lgtm ACK [bbb68ff](bitcoin@bbb68ff) ns-xvrn: ACK bbb68ff achow101: ACK bbb68ff Tree-SHA512: fcbe195874dd4aa9e86548685b6b28595a2c46f9869b79b6e2b3835f76b49cab4bef6a59c8ad6428063a41b7bb6f687229b06ea614fbd103e0531104af7de55d
27b168b Update help text for spend and rawtransaction rpcs (Michael Tidwell) Pull request description: The "data" field without outputs was marked as "required" in the help docs when using bitcoin-cli. This field when left off worked as an intended optional OP_RETURN. closes bitcoin#27828. Motivation: It is hard to understand that "data" is actually optional for commands like `createpsbt` and `walletcreatefundedpsbt`. ACKs for top commit: achow101: ACK 27b168b Sjors: tACK 27b168b Tree-SHA512: 235e7ed4af69880880c04015b3f7de72c8f31ae035485c4c64c483e282948f3ea3f1eef16f15e260a1aaf21114150713516ba6a99967ccad9ecd91ff67cb0450
vijaydasmp
force-pushed
the
Feb_2026_01
branch
from
11bb248 to
b39ec50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports