backport: Merge bitcoin/bitcoin#28644, gui#765 , 28184, 27944

[vijaydasmp]

Bitcoin Backporting work

[github-actions]

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

[github-actions]

This pull request has conflicts, please rebase.

[coderabbitai]

Walkthrough

The pull request contains changes across the Qt GUI layer, functional tests, and configuration scripts. In the main functional change, bitcoingui.cpp refactors wallet-related action bindings to route through a WalletController instance instead of inline lambdas, centralizing wallet lifecycle management. Additional UI shutdown handling logic is introduced for menu clearing during client shutdown. The functional tests are refactored to accumulate actual events and compare them against expected events post-execution rather than asserting within callbacks. Configuration updates include disabling value profiling in the fuzzing merge workflow and adjusting the mypy cache directory path to use a relative path from the repository root.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title references specific upstream PR numbers (bitcoin#28644, gui#765, 28184, 27944) and matches the commit summaries showing actual backporting of GUI wallet controller routing, fuzzing profile changes, mypy cache handling, and test refactoring work.
Description check	✅ Passed	The description 'Bitcoin Backporting work' is minimal but directly relevant to the changeset, which consists entirely of backporting commits from upstream Bitcoin projects as indicated by the title and commit messages.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

test/functional/interface_usdt_validation.py (1)

99-137: ⚠️ Potential issue | 🔴 Critical

events is never populated, so Line 136 will always fail.

Line 136 asserts len(events) == BLOCKS_EXPECTED, but handle_blockconnected() never appends to events. This makes the test fail even when tracepoints are correct.

Suggested fix

 def handle_blockconnected(_, data, __):
     event = ctypes.cast(data, ctypes.POINTER(Block)).contents
     self.log.info(f"handle_blockconnected(): {event}")
-    block_hash = bytes(event.hash[::-1]).hex()
-    block = expected_blocks[block_hash]
-    assert_equal(block["hash"], block_hash)
-    assert_equal(block["height"], event.height)
-    assert_equal(len(block["tx"]), event.transactions)
-    assert_equal(len([tx["vin"] for tx in block["tx"]]), event.inputs)
-    assert_equal(0, event.sigops)  # no sigops in coinbase tx
-    # only plausibility checks
-    assert event.duration > 0
-    del expected_blocks[block_hash]
+    events.append(event)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/functional/interface_usdt_validation.py` around lines 99 - 137, The test
fails because the events list is never populated; initialize a shared list
(e.g., events = []) before defining handle_blockconnected and append the
received event (or a lightweight copy of it) inside handle_blockconnected (the
callback registered via
bpf["block_connected"].open_perf_buffer(handle_blockconnected)); ensure you
append the same event object shape expected later (the variable named event used
in the later loop) so the final assertions and len(events) == BLOCKS_EXPECTED
succeed.

src/qt/bitcoingui.cpp (1)

555-620: ⚠️ Potential issue | 🔴 Critical

Use this as connection context for wallet actions instead of null m_wallet_controller.

createActions() executes during construction (line 157) when m_wallet_controller is still nullptr (initialized at line 122). Using nullptr as the Qt::connect context object on lines 555, 583, 609, 612, 618 bypasses Qt's automatic signal-slot lifecycle management. When the context object is null, Qt cannot properly manage connection cleanup, creating a resource management issue.

Replace m_wallet_controller with this as the context object and add null checks inside each lambda, as the suggested fix shows. This ensures wallet actions are properly lifecycle-managed through BitcoinGUI.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/qt/bitcoingui.cpp` around lines 555 - 620, The connect calls for
wallet-related actions (the QMenu aboutToShow lambda using
m_wallet_controller->listWalletDir(), and the triggered handlers for
m_restore_wallet_action/CreateWalletActivity/RestoreWalletActivity/CloseWalletActivity/closeAllWallets
via m_close_wallet_action, m_create_wallet_action, m_close_all_wallets_action)
currently use m_wallet_controller as the connection context even though it can
be nullptr during construction; change the context argument in these
connect(...) calls from m_wallet_controller to this, and inside each lambda add
a guard that returns early if m_wallet_controller is nullptr before calling
methods like m_wallet_controller->listWalletDir(), creating activities that take
m_wallet_controller, or calling
m_wallet_controller->closeWallet()/closeAllWallets(); this preserves Qt's
automatic connection cleanup while avoiding dereferencing a null
m_wallet_controller.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/qt/bitcoingui.cpp`:
- Around line 555-620: The connect calls for wallet-related actions (the QMenu
aboutToShow lambda using m_wallet_controller->listWalletDir(), and the triggered
handlers for
m_restore_wallet_action/CreateWalletActivity/RestoreWalletActivity/CloseWalletActivity/closeAllWallets
via m_close_wallet_action, m_create_wallet_action, m_close_all_wallets_action)
currently use m_wallet_controller as the connection context even though it can
be nullptr during construction; change the context argument in these
connect(...) calls from m_wallet_controller to this, and inside each lambda add
a guard that returns early if m_wallet_controller is nullptr before calling
methods like m_wallet_controller->listWalletDir(), creating activities that take
m_wallet_controller, or calling
m_wallet_controller->closeWallet()/closeAllWallets(); this preserves Qt's
automatic connection cleanup while avoiding dereferencing a null
m_wallet_controller.

In `@test/functional/interface_usdt_validation.py`:
- Around line 99-137: The test fails because the events list is never populated;
initialize a shared list (e.g., events = []) before defining
handle_blockconnected and append the received event (or a lightweight copy of
it) inside handle_blockconnected (the callback registered via
bpf["block_connected"].open_perf_buffer(handle_blockconnected)); ensure you
append the same event object shape expected later (the variable named event used
in the later loop) so the final assertions and len(events) == BLOCKS_EXPECTED
succeed.

---

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c0f42a and 5d091d3.

📒 Files selected for processing (6)

• src/qt/bitcoingui.cpp
• test/functional/interface_usdt_net.py
• test/functional/interface_usdt_utxocache.py
• test/functional/interface_usdt_validation.py
• test/fuzz/test_runner.py
• test/lint/lint-python.py