Fix color management issue on windows #20054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
reviewed
Jan 2, 2026
src/common/colorspaces.c
Outdated
| GdkWindow *window = gtk_widget_get_window(widget); | ||
| HWND hwnd = (HWND)gdk_win32_window_get_handle(window); // get window handle | ||
| HMONITOR hMonitor = MonitorFromWindow(hwnd, MONITOR_DEFAULTTONEAREST); // get monitor handle | ||
| if(!hMonitor){ return;} //TODO log error |
Member
There was a problem hiding this comment.
As we are at it, can you please add some log:
dt_print(DT_DEBUG_ALWAYS, "[win32 dt_colorspaces_set_display_profile] <ERROR MESS HERE>");
src/common/colorspaces.c
Outdated
| if(!hMonitor){ return;} //TODO log error | ||
| MONITORINFOEX monitorInfo; | ||
| monitorInfo.cbSize = sizeof(MONITORINFOEX); | ||
| if(!GetMonitorInfoW(hMonitor,(LPMONITORINFO) &monitorInfo)) { return;} //get monitor info , TODO log error |
src/common/colorspaces.c
Outdated
| if(!hMonitor){ return;} //TODO log error | ||
| MONITORINFOEX monitorInfo; | ||
| monitorInfo.cbSize = sizeof(MONITORINFOEX); | ||
| if(!GetMonitorInfoW(hMonitor,(LPMONITORINFO) &monitorInfo)) { return;} //get monitor info , TODO log error |
Member
There was a problem hiding this comment.
style: We need a space after coma.
src/common/colorspaces.c
Outdated
| MONITORINFOEX monitorInfo; | ||
| monitorInfo.cbSize = sizeof(MONITORINFOEX); | ||
| if(!GetMonitorInfoW(hMonitor,(LPMONITORINFO) &monitorInfo)) { return;} //get monitor info , TODO log error | ||
| HDC hdc = CreateIC(L"MONITOR",monitorInfo.szDevice,NULL,NULL); // get device-info context of the monitor |
Member
There was a problem hiding this comment.
style: We need a space after coma.
TurboGit
added
scope: windows support
Author
|
Ok, it's updated. |
TurboGit
requested changes
Jan 4, 2026
| GdkWindow *window = gtk_widget_get_window(widget); | ||
| HWND hwnd = (HWND)gdk_win32_window_get_handle(window); // get window handle | ||
| HMONITOR hMonitor = MonitorFromWindow(hwnd, MONITOR_DEFAULTTONEAREST); // get monitor handle | ||
| if(!hMonitor){ dt_print(DT_DEBUG_ALWAYS, "[win32 dt_colorspaces_set_display_profile] error getting monitor handle"); return;} |
Member
There was a problem hiding this comment.
Style: as I said { should be on its own line. Please try to follow current style.
if(!hMonitor)
{
dt_print(DT_DEBUG_ALWAYS, "[win32 dt_colorspaces_set_display_profile] error getting monitor handle");
return;
}
| if(!hMonitor){ dt_print(DT_DEBUG_ALWAYS, "[win32 dt_colorspaces_set_display_profile] error getting monitor handle"); return;} | ||
| MONITORINFOEX monitorInfo; | ||
| monitorInfo.cbSize = sizeof(MONITORINFOEX); | ||
| if(!GetMonitorInfoW(hMonitor, (LPMONITORINFO) &monitorInfo)) //get monitor info |
Member
There was a problem hiding this comment.
Likewise, { should be under if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just taken from git-db-usr@262b8a6
Since nobody has created PR from it before, i will just open one.