Safe gphoto backthread starting #20025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
reviewed
Dec 29, 2025
src/common/camera_control.c
Outdated
|
|
||
| dt_control_t *control = darktable.control; | ||
| dt_atomic_add_int(&control->running_jobs, 1); | ||
| g_usleep(100000); // no haste, keep going in main thread |
Collaborator
There was a problem hiding this comment.
I'd recommend adding another zero to make it a full second, to be extra-sure that we don't accidentally skip the run loop because it took a while for dt_control_running to actually return TRUE. As the comment says, no haste....
jenshannoschwalm
force-pushed
the
safer_gphoto_starting
branch
from
87b7760 to
80ffacf
Compare
Following 6d50199. We start the gphoto thread after all job threads are up&running and continue in `dt_control_jobs_init()` after the photothread is up&running. Make sure we usleep() also if there is currently no cam_ctrl
jenshannoschwalm
force-pushed
the
safer_gphoto_starting
branch
from
80ffacf to
9bd320a
Compare
Collaborator
Author
|
Let's see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 6d50199. We start the gphoto thread after all job threads are up&running and continue in
dt_control_jobs_init()after the photothread is up&running.@wpferguson this is fixing a second potential cause of race conditions related to back threads.
@TurboGit for me again a safe one.