-
Notifications
You must be signed in to change notification settings - Fork 341
DAOS-18375 control: Set scm_hugepages_disabled default to true #17526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Ticket title is 'Set scm_hugepages_disabled default to true' |
|
Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/1/execution/node/1356/log |
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/1/execution/node/1336/log |
knard38
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding there is some minor fixes to be done.
| @@ -420,7 +420,8 @@ | |||
| # # When class is set to ram, tmpfs will be mounted with hugepage | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments associated to scm_hugepages_disabled should probably be updated as it will be mounted without huge page enabled by default from my understanding.
| `, | ||
| expResult: true, | ||
| }, | ||
| // "explicitly set to false": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove as it is tested in TestStorage_ScmConfig_DisableHugepages_MultipleEngines ?
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/2/execution/node/468/log |
Set scm_hugepages_disabled to true in yaml unmarshal function before
unmarshalling so the default is true if unset in the config file.
Features: control
Steps for the author:
After all prior steps are complete: