Skip to content

Conversation

@tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Feb 8, 2026

Set scm_hugepages_disabled to true in yaml unmarshal function before
unmarshalling so the default is true if unset in the config file.

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested review from a team as code owners February 8, 2026 13:39
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

Ticket title is 'Set scm_hugepages_disabled default to true'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18375

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/1/execution/node/1356/log

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/1/execution/node/1336/log

@tanabarr tanabarr self-assigned this Feb 9, 2026
@tanabarr tanabarr requested review from kjacque, knard38 and mjmac February 9, 2026 10:22
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding there is some minor fixes to be done.

@@ -420,7 +420,8 @@
# # When class is set to ram, tmpfs will be mounted with hugepage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments associated to scm_hugepages_disabled should probably be updated as it will be mounted without huge page enabled by default from my understanding.

`,
expResult: true,
},
// "explicitly set to false": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove as it is tested in TestStorage_ScmConfig_DisableHugepages_MultipleEngines ?

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17526/2/execution/node/468/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants