Jlo/posix default by johannlombardi · Pull Request #17516 · daos-stack/daos

johannlombardi · 2026-02-05T15:46:36Z

DAOS-17946 cont: use POSIX container type by default in daos utility

Change the default to POSIX container in the daos utility when no container
type is specified on the command line.

Signed-off-by: Johann Lombardi johann.lombardi@hpe.com

Change the default to POSIX container in the daos utility when no container type is specified on the command line. Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

github-actions · 2026-02-05T15:52:15Z

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Jlo/posix

daltonbohning · 2026-02-05T16:09:28Z

src/tests/ftest/util/test_utils_container.py

        # method when creating/destroying containers
        self.path = BasicParameter(None)
-        self.type = BasicParameter(None)
+        self.type = BasicParameter("NONE")


I wrote a script to find all the configs where we do not specify the type, and there are 42 of them. Although it's more changes, I think it's better overall . Are you okay with me pushing that instead of setting the default here?

sure, please feel free to push it in this PR.

Thanks. Pushed. It should cover almost all the cases, if not all

phender · 2026-02-05T16:12:31Z

src/tests/ftest/util/test_utils_container.py

        # method when creating/destroying containers
        self.path = BasicParameter(None)
-        self.type = BasicParameter(None)
+        self.type = BasicParameter("NONE")


Leaving this set as the type None results in a daos container create command that excludes the --type argument. Setting the default to the "NONE" string results in a daos container create command with the --type=NONE argument. Based upon the commit message don't we want thew first option, where the --type argument is excluded?

If --type is excluded, the default container type will now be POSIX.
So if we leave this as None we will need to update all tests that currently create a container but do not specify a type. And IMO that's what we should do, instead of setting a different default value here

Correct, it will pass the string "NONE" which will restore the old default. I am fine with Dalton's approach.

I'm a little confused by the approach of changing all the config files. Do the tests actually need the type to be NONE for the purpose of the test itself, or is it some outdated expectation? If the latter, shouldn't the tests be fixed to expect the new default? (Or if it doesn't matter to the test, maybe not compare the layout type at all?)

Tests using NONE type are working with non-POSIX containers. I.e. using the daos_ API directly. So they don't want to use POSIX. But as a side note, I do think most of those tests should eventually be updated to use POSIX instead

Ah, I see. That makes sense if the test requires direct API access. As an aside, I think the NONE type is a bit of a misnomer--should be called "API" or something like that.

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

Features: container Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

phender · 2026-02-05T23:24:47Z

src/tests/ftest/dfuse/container_type.yaml

 container:
  cont_types:
-    - ""
+    - "NONE"


Shouldn't we still test "" in addition to "NONE"?

Suggested change

- "NONE"

- ""

- "NONE"

We also might want to clarify https://github.com/daos-stack/daos/blob/master/src/tests/ftest/dfuse/container_type.py#L43, now that "NONE" should create a POSIX container.

Either way https://github.com/daos-stack/daos/blob/master/src/tests/ftest/dfuse/container_type.py#L48-L49 will need to be updated to support setting "NONE".

I fixed the python, but the purpose of this test is to verify dfuse behavior with POSIX and non-POSIX, so I don't think there is any need to create a container with an empty type

Features: container Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

kjacque · 2026-02-06T01:55:04Z

src/control/cmd/daos/container.go

+	// Use POSIX container type by default, if none is specified
+	typeProp := createPropList.MustAddEntryByType(daos.ContainerPropLayoutType)
 	if hasType() {
-		typeProp := createPropList.MustAddEntryByType(daos.ContainerPropLayoutType)
 		typeProp.SetValue(uint64(cmd.Type.Type))
+	} else {
+		typeProp.SetValue(uint64(C.DAOS_PROP_CO_LAYOUT_POSIX))


Would be better to add these C layout types as Go constants in src/control/lib/daos/container_property.go, and then use the constant here.

I wouldn't block on this -- we're still making some changes around the way we organize the cgo code.

kjacque · 2026-02-06T02:02:42Z

src/tests/ftest/util/test_utils_container.py

        # method when creating/destroying containers
        self.path = BasicParameter(None)
-        self.type = BasicParameter(None)
+        self.type = BasicParameter("NONE")


I'm a little confused by the approach of changing all the config files. Do the tests actually need the type to be NONE for the purpose of the test itself, or is it some outdated expectation? If the latter, shouldn't the tests be fixed to expect the new default? (Or if it doesn't matter to the test, maybe not compare the layout type at all?)

daosbuild3 · 2026-02-06T13:54:50Z

Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17516/4/execution/node/826/log

daosbuild3 · 2026-02-06T16:50:06Z

Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17516/5/execution/node/679/log

daosbuild3 · 2026-02-06T17:06:08Z

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17516/5/testReport/

johannlombardi added 2 commits February 5, 2026 16:41

DAOS-17946 cont: use POSIX container type by default in daos utility

ee71448

Change the default to POSIX container in the daos utility when no container type is specified on the command line. Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

Change default in NLT.

4ce4b15

Signed-off-by: Johann Lombardi <johann.lombardi@hpe.com>

johannlombardi requested review from a team as code owners February 5, 2026 15:46

johannlombardi requested a review from phender February 5, 2026 15:47

daltonbohning reviewed Feb 5, 2026

View reviewed changes

phender reviewed Feb 5, 2026

View reviewed changes

daltonbohning added 3 commits February 5, 2026 19:13

set type: NONE explicitly for each ftest

132ad95

Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

do not set global default in ftest

e329783

Features: container Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

update copyright

74b1d41

Features: container Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

phender requested changes Feb 5, 2026

View reviewed changes

fix dfuse/container_type test

471245c

Features: container Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>

kjacque reviewed Feb 6, 2026

View reviewed changes

Conversation

johannlombardi commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Feb 6, 2026

Uh oh!

daosbuild3 commented Feb 6, 2026

Uh oh!

daosbuild3 commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

johannlombardi commented Feb 5, 2026 •

edited

Loading

kjacque Feb 6, 2026 •

edited

Loading

kjacque Feb 6, 2026 •

edited

Loading