Skip to content

DAOS-18487 rebuild: refine rebuild completion detecting #17508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gnailzenh merged 1 commit into from
Feb 10, 2026
Merged

DAOS-18487 rebuild: refine rebuild completion detecting #17508

gnailzenh merged 1 commit into from
Feb 10, 2026
+20 −13

Conversation

@liuxuezhao
Copy link
Contributor

@liuxuezhao liuxuezhao commented Feb 5, 2026

dms.dm_migrating status only can be trust when scan global done, so get rt_global_scan_done firstly before checking dms.dm_migrating. and some log refining.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@liuxuezhao @gnailzenh @wangshilong
DAOS-18487 rebuild: refine rebuild_tgt_query
c7c2379 
dms.dm_migrating status only can be trust when scan global done,
so get rt_global_scan_done firstly before checking dms.dm_migrating.
and some log refining.

Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
Co-authored-by: Liang Zhen <gnailzenh@gmail.com>
Co-authored-by: Wang Shilong <shilong.wang@hpe.com>
@liuxuezhao liuxuezhao requested review from a team as code owners February 5, 2026 06:36
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-18487

@liuxuezhao liuxuezhao changed the title DAOS-18487 rebuild: refine rebuild_tgt_query DAOS-18487 rebuild: refine rebuild completion processing Feb 5, 2026
@liuxuezhao liuxuezhao changed the title DAOS-18487 rebuild: refine rebuild completion processing DAOS-18487 rebuild: refine rebuild completion detecting Feb 5, 2026
@gnailzenh gnailzenh assigned kccain and unassigned kccain Feb 5, 2026
@gnailzenh gnailzenh requested a review from kccain February 5, 2026 07:10
Nasf-Fan
Nasf-Fan approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@Nasf-Fan Nasf-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent finding out such race!

kccain
kccain approved these changes Feb 5, 2026
View reviewed changes
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 5, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17508/1/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 9, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17508/2/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 9, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17508/2/execution/node/1338/log

@liuxuezhao
Copy link
Contributor Author

liuxuezhao commented Feb 10, 2026

two test failures are known issues -
one is NLT failure, another is https://daosio.atlassian.net/browse/DAOS-18466

@gnailzenh gnailzenh merged commit 0f60bbf into master Feb 10, 2026
41 of 44 checks passed
@gnailzenh gnailzenh deleted the lxz/rb_scan_fix_master branch February 10, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kccain kccain kccain approved these changes

@wangshilong wangshilong wangshilong approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@NiuYawei NiuYawei Awaiting requested review from NiuYawei

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liuxuezhao @daosbuild3 @wangshilong @gnailzenh @Nasf-Fan @kccain