Skip to content

DAOS-18570 control: Allow net-test with non-default system#17507

Merged
daltonbohning merged 3 commits intomasterfrom
kjacque/self-test-sys-name
Feb 17, 2026
Merged

DAOS-18570 control: Allow net-test with non-default system#17507
daltonbohning merged 3 commits intomasterfrom
kjacque/self-test-sys-name

Conversation

@kjacque
Copy link
Contributor

@kjacque kjacque commented Feb 5, 2026 •
edited
Loading

  • Call GetAttachInfo if system name isn't supplied when calling
    daos health net-test.
  • Fix a crash that occurred displaying net-test results if all
    RPCs failed.

Features: control daos_cmd

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@kjacque kjacque self-assigned this Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026 •
edited
Loading

Ticket title is 'Allow daos health net-test to work with non-default system name'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18570

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 5, 2026

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17507/1/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 5, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17507/1/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 5, 2026

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17507/1/display/redirect

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 5, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17507/1/execution/node/1286/log

@kjacque
DAOS-18570 control: Allow net-test with non-default system
16ce562 
- Call GetAttachInfo if system name isn't supplied when calling
  daos health net-test.
- Fix a crash that occurred displaying net-test results if all
  RPCs failed.

Features: control daos_cmd

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@kjacque kjacque force-pushed the kjacque/self-test-sys-name branch from 7559e13 to 16ce562 Compare February 11, 2026 17:01
@kjacque kjacque changed the title DAOS-18570 cart: Allow self-test with non-default system DAOS-18570 cart: Allow net-test with non-default system Feb 11, 2026
@kjacque kjacque marked this pull request as ready for review February 12, 2026 00:39
@kjacque kjacque requested review from a team as code owners February 12, 2026 00:39
knard38
knard38 previously approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just minor details regarding test.

src/control/cmd/daos/pretty/selftest_test.go
Client/Server Network Test Summary
----------------------------------
Server Endpoints: [0-2]:0
RPC Throughput : 1176.47 RPC/s
Copy link
Contributor

@knard38 knard38 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound strange to have RPC performance results if all RPC failed.

Copy link
Contributor Author

@kjacque kjacque Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, in this situation the results look pretty weird. I was reluctant to change too much of the display details in this PR though.

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 12, 2026

Test stage Functional Hardware Large MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17507/2/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Feb 13, 2026

Test failure is unrelated: https://daosio.atlassian.net/browse/DAOS-18576

kjacque
kjacque commented Feb 13, 2026
View reviewed changes
@kjacque
Merge branch 'master' into kjacque/self-test-sys-name
4c889e8
@kjacque
Return error when get sys info fails
26e71bd 
Also cleaned up cruft from an earlier implementation.

Features: control daos_cmd

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 13, 2026

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17507/3/execution/node/1315/log

@kjacque kjacque requested a review from knard38 February 14, 2026 00:43
@kjacque
Copy link
Contributor Author

kjacque commented Feb 14, 2026

Unrelated test failures:

  • DAOS-18455
  • DAOS-18576 - Looks like the fix for this landed to master today but I haven't pulled it into this PR branch yet.

@kjacque kjacque changed the title DAOS-18570 cart: Allow net-test with non-default system DAOS-18570 control: Allow net-test with non-default system Feb 14, 2026
@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 17, 2026
@kjacque kjacque requested a review from a team February 17, 2026 18:02
@daltonbohning daltonbohning merged commit 7ed838b into master Feb 17, 2026
48 of 52 checks passed
@daltonbohning daltonbohning deleted the kjacque/self-test-sys-name branch February 17, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjmac mjmac mjmac approved these changes

@knard38 knard38 knard38 approved these changes

@tanabarr tanabarr Awaiting requested review from tanabarr

Assignees

@kjacque kjacque

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kjacque @daosbuild3 @mjmac @knard38 @daltonbohning