DAOS-18567 bio: Set SPDK/DPDK engine log level via env by tanabarr · Pull Request #17497 · daos-stack/daos

tanabarr · 2026-02-03T18:47:00Z

Allow administrator to configure the engine process log levels for
SPDK and DPDK via environment variables DAOS_XPDK_LOG_LEVEL. SPDK
accepts 0-4 (ERR,WARN,NOTICE,INFO,DEBUG) and DPDK accepts 1-8.

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

github-actions · 2026-02-03T18:53:11Z

Ticket title is 'Set SPDK & DPDK log levels via engine environment variables'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18567

NiuYawei · 2026-02-04T01:57:10Z

@tanabarr is this for replacing #17488 ?

daosbuild3 · 2026-02-04T03:41:20Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17497/1/testReport/

daosbuild3 · 2026-02-04T03:44:33Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/1/execution/node/984/log

daosbuild3 · 2026-02-04T03:51:01Z

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/1/execution/node/1029/log

tanabarr · 2026-02-04T10:11:01Z

@tanabarr is this for replacing #17488 ?

yes

…ggle-spdk-dbg2 Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

NiuYawei · 2026-02-05T02:20:17Z

src/bio/bio_xstream.c

+		       DAOS_DPDK_LOG_DEFAULT);
+		dpdk_level = DAOS_DPDK_LOG_DEFAULT;
+	} else {
+		D_INFO("DPDK log level is %u\n", dpdk_level);


Minor: we could combine the "DPDK & SPDK log level" message into single D_INFO.

knard38

LGTM, just a minor non blocking remark.

knard38 · 2026-02-05T09:11:19Z

src/bio/bio_xstream.c

+/* Max SPDK log level */
+#define DAOS_SPDK_LOG_MAX       SPDK_LOG_DEBUG
+/* Default DPDK log level: RTE_LOG_ERR */
+#define DAOS_DPDK_LOG_DEFAULT   4


NIT: Could be nice to define it in a .h file to make it accessible in spdk_default.go and thus not call C.dpdk_cli_build_opts(4, 4) with hard coded parameter values

daosbuild3 · 2026-02-06T15:20:15Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/3/execution/node/766/log

daosbuild3 · 2026-02-06T21:39:14Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/4/execution/node/431/log

daosbuild3 · 2026-02-06T22:09:50Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/5/execution/node/431/log

kjacque

Comments are minor and could be addressed in a follow-on.

kjacque · 2026-02-06T23:10:59Z

src/control/lib/spdk/spdk_default.go

 	}

-	envCtx := C.dpdk_cli_override_opts
+	envCtx := C.dpdk_cli_build_opts(4, 4)


Magic numbers?

kjacque · 2026-02-06T23:13:02Z

src/include/daos_srv/control.h

+ * DPDK log level (1-8): 1=EMERG, 2=ALERT, 3=CRIT, 4=ERR, 5=WARNING,
+ *                       6=NOTICE, 7=INFO, 8=DEBUG


If we can't include these from some dpdk header file, it would be better to define our own enum than to embed the meaning in a comment here.

kjacque · 2026-02-06T23:13:39Z

src/include/daos_srv/control.h

+ * DPDK log level (1-8): 1=EMERG, 2=ALERT, 3=CRIT, 4=ERR, 5=WARNING,
+ *                       6=NOTICE, 7=INFO, 8=DEBUG
+ *
+ * \param eal_level      Log level for EAL facility (1-8)


Maybe a dumb question, but what does EAL stand for?

kjacque · 2026-02-06T23:14:56Z

src/common/control.c

+	}
+
+	/* Build with custom EAL level, others at default */
+	ret = snprintf(dpdk_cli_opts_buffer, sizeof(dpdk_cli_opts_buffer),


Looks like this function is only called during bio init, but it'd be good to note in the comments that it's not thread-safe.

kjacque · 2026-02-06T23:16:37Z

src/common/control.c

+	if (ret < 0 || ret >= sizeof(dpdk_cli_opts_buffer)) {
+		return NULL;


I think we should log an error here. If snprintf fails, it would be nice to know why.

…ggle-spdk-dbg2 Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

daosbuild3 · 2026-02-07T14:56:10Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17497/6/testReport/

daosbuild3 · 2026-02-07T17:10:51Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/6/execution/node/984/log

daosbuild3 · 2026-02-07T21:12:20Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/6/execution/node/1089/log

daosbuild3 · 2026-02-07T21:25:55Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/7/execution/node/446/log

daosbuild3 · 2026-02-08T16:34:26Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/8/execution/node/445/log

daosbuild3 · 2026-02-08T18:49:10Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/8/execution/node/491/log

daosbuild3 · 2026-02-08T19:05:49Z

Test stage Fault injection testing on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17497/9/execution/node/445/log

DAOS-18567 bio: Set SPDK/DPDK engine log level via env

fc6e499

Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

tanabarr requested review from a team as code owners February 3, 2026 18:47

tanabarr self-assigned this Feb 3, 2026

tanabarr requested review from NiuYawei, kjacque and knard38 February 3, 2026 18:47

Merge remote-tracking branch 'origin/master' into tanabarr/control-to…

6a6216e

…ggle-spdk-dbg2 Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

NiuYawei approved these changes Feb 5, 2026

View reviewed changes

knard38 approved these changes Feb 5, 2026

View reviewed changes

kjacque approved these changes Feb 6, 2026

View reviewed changes

Merge remote-tracking branch 'origin/master' into tanabarr/control-to…

365d6f4

…ggle-spdk-dbg2 Features: control Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>

		* DPDK log level (1-8): 1=EMERG, 2=ALERT, 3=CRIT, 4=ERR, 5=WARNING,
		* 6=NOTICE, 7=INFO, 8=DEBUG

		if (ret < 0 \|\| ret >= sizeof(dpdk_cli_opts_buffer)) {
		return NULL;

Conversation

tanabarr commented Feb 3, 2026

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

NiuYawei commented Feb 4, 2026

Uh oh!

daosbuild3 commented Feb 4, 2026

Uh oh!

daosbuild3 commented Feb 4, 2026

Uh oh!

daosbuild3 commented Feb 4, 2026

Uh oh!

tanabarr commented Feb 4, 2026

Uh oh!

NiuYawei Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

knard38 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Feb 6, 2026

Uh oh!

daosbuild3 commented Feb 6, 2026

Uh oh!

daosbuild3 commented Feb 6, 2026

Uh oh!

kjacque left a comment

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kjacque Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

daosbuild3 commented Feb 7, 2026

Uh oh!

daosbuild3 commented Feb 7, 2026

Uh oh!

daosbuild3 commented Feb 7, 2026

Uh oh!

daosbuild3 commented Feb 7, 2026

Uh oh!

daosbuild3 commented Feb 8, 2026

Uh oh!

daosbuild3 commented Feb 8, 2026

Uh oh!

daosbuild3 commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

knard38 left a comment •

edited

Loading