Skip to content

DAOS-16935 cart: add D_MEM_DEVICE and cio_mem_device init option #15937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
soumagne wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DAOS-16935 cart: add D_MEM_DEVICE and cio_mem_device init option #15937

soumagne wants to merge 1 commit into from
+259 −297

Conversation

@soumagne
Copy link
Collaborator

@soumagne soumagne commented Feb 19, 2025

This enables the detection and use of memory devices for RMA transfers

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@soumagne soumagne requested review from a team as code owners February 19, 2025 00:26
@github-actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

Ticket title is 'dfs_write bad address from 32K buffer allocated with malloc_shared'
Status is 'In Progress'
Labels: 'ALCF,alcf_cluster'
https://daosio.atlassian.net/browse/DAOS-16935

@daosbuild1
Copy link
Collaborator

daosbuild1 commented Feb 19, 2025

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15937/1/execution/node/1420/log

frostedcmos
frostedcmos reviewed Feb 21, 2025
View reviewed changes
@soumagne soumagne force-pushed the soumagne/crt_mem_device branch from f7e7aee to cfe966c Compare February 9, 2026 17:41
frostedcmos
frostedcmos reviewed Feb 9, 2026
View reviewed changes
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Feb 10, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-15937/3/execution/node/1347/log

@soumagne
DAOS-16935 cart: add D_MEM_DEVICE and cio_mem_device init option
ec5dc4f 
This enables the detection and use of memory devices for RMA transfers

Clean up cart init info print

Consolidate parsing of cart init options

Signed-off-by: Jerome Soumagne <jerome.soumagne@hpe.com>
@soumagne soumagne force-pushed the soumagne/crt_mem_device branch from fe6fb1d to ec5dc4f Compare February 11, 2026 22:46
@soumagne soumagne requested a review from frostedcmos February 11, 2026 22:48
frostedcmos
frostedcmos reviewed Feb 11, 2026
View reviewed changes
src/cart/crt_init.c
D_INFO("interface = %s\n", opt->cio_interface);
D_INFO("domain = %s\n", opt->cio_domain);
D_INFO("port = %s\n", opt->cio_port);
if (opt->cio_auth_key)
Copy link
Contributor

@frostedcmos frostedcmos Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need if () here if we are just going to print opt->cio_auth_key value. previously we only printed if it was set or not. and then likewise D_AUTH_KEY environment variable should be changed from ENV_STR_NO_PRINT to ENV_STR to have the same corresponding behavior with opt

Copy link
Collaborator Author

@soumagne soumagne Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I will fix that once the CI finishes

src/cart/crt_init.c
static const char *const crt_tc_name[] = {CRT_TRAFFIC_CLASSES};
#undef X

#define CRT_ENV_OPT_GET(opt, x, env) \
Copy link
Contributor

@frostedcmos frostedcmos Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frostedcmos frostedcmos frostedcmos left review comments

@jgmoore-or jgmoore-or Awaiting requested review from jgmoore-or

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soumagne @daosbuild1 @daosbuild3 @frostedcmos