FileLister: ensure sorting of files / some cleanups#6322
Merged
firewave merged 3 commits intodanmar:mainfrom Apr 22, 2024
Merged
FileLister: ensure sorting of files / some cleanups#6322firewave merged 3 commits intodanmar:mainfrom
firewave merged 3 commits intodanmar:mainfrom
Conversation
firewave
changed the title
danmar
reviewed
Apr 22, 2024
danmar
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4748 exposed a different order of files using the Windows code. This was caused by it only sorting the files in case of recursive parsing. But we need to sort all the files and not just the directory contents as the directory order might also be different dependent on the filesystem. This also allows the code to be a bit closer between the implementations.