fix: Respect terminal ansi colors / background#18
Merged
Conversation
damassi
force-pushed
the
fix/support-terminal-background
branch
4 times, most recently
from
d17f7fa to
785111b
Compare
damassi
force-pushed
the
fix/support-terminal-background
branch
from
785111b to
b5569a6
Compare
damassi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a headache. Finally figured out how to support proper terminal backgrounds -- ie, don't apply textual color modes, but respect the users environment. This gives us support for inheriting the background color of the users terminal, and not plop in an arbitrary background, which makes the terminal app feel clunky and slow.