introduces macos and windows runners in build step#279
Open
bobrossthepainter wants to merge 20 commits intomasterfrom
Open
introduces macos and windows runners in build step#279bobrossthepainter wants to merge 20 commits intomasterfrom
bobrossthepainter wants to merge 20 commits intomasterfrom
Conversation
Contributor
|
This PR is almost 1y old. Can a review be provided please ? |
Owner
|
@bobrossthepainter what's the state of this? does it make sense to have this merged in? |
cmoulliard
reviewed
Feb 10, 2025
| # echo "::set-output name=matrix::$matrix" | ||
|
|
||
| # MacOs Single Test | ||
| matrix=$( echo '{"version":["ApiServerContainer 1.30.0"],"os":["macos-12"]}' | jq -c '.') |
Contributor
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Hi @cmoulliard, thanks almost forgot this PR. I will provide an update here within the next week.
| if: runner.os == 'macos' | ||
| run: | | ||
| brew install docker colima docker-buildx | ||
| colima start --network-address |
Contributor
There was a problem hiding this comment.
Why do you use colima and not podman ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies working developer-builds on different os'