fix: various accessibility fixes #5399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AmarTrebinjac
changed the title
AmarTrebinjac
force-pushed
the
ENG-474
branch
from
8251119 to
7ef7d90
Compare
AmarTrebinjac
commented
Jan 28, 2026
| ref: MutableRefObject<HTMLLabelElement>, | ||
| ): ReactElement { | ||
| return ( | ||
| // eslint-disable-next-line jsx-a11y/label-has-associated-control |
Contributor
Author
There was a problem hiding this comment.
This doesn't seem to be working properly. It should not give us an error if the input is a child of the label, but it does.
I removed the htmlfor on the label element because having the label be the parent + setting the htmlfor manually creates double labeling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Various fixes for accessibility. Noticed I had a gazillion errors on my profile page:
So took it upon myself to fix them
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://eng-474.preview.app.daily.dev