Fix crash when parsing f-strings with single-letter content like F #10295
+42
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
PythonParser.tswhen parsing YAML values that get interpreted as f-strings with single-letter content.When the YAML schema compiler processes string values, it wraps them as
f"..."for interpolation support. However, single letters likeFbecomef"F"which causes the Python parser to crash with "Cannot read properties of undefined (reading 'type')" because the parser doesn't handle empty children arrays.The Bug
In
YamlCompiler.ts, all YAML string values get wrapped as f-strings:When the value is just
F, it becomesf"F"which theString_templateContexthandler tries to process butchildrenarray is empty, causing:The Fix
Added an early return in
PythonParser.tsto handle the empty children case:Reproducer
This YAML schema causes the crash:
Test
Added a test case in
yaml-schema.test.tsto prevent regression.Checklist