WIP #250 Initial work towards testing with BrowserStack #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this is just one browser, with a first stab at the CI logic and test logic to do this. I've not tried any of this out locally yet but conceptually everything's here.
craigfowler
commented
Jan 24, 2026
Member
Author
craigfowler
left a comment
craigfowler
left a comment
There was a problem hiding this comment.
This will resolve #250.
Small improvements
This is to see what's happening in WebDriverExtensions. I suspect that it's rejecting my config, but it really doesn't need to.
This should fix the error I'm getting about the config not existing.
I made a mistake with an env variable name, so my logic wasn't being executed.
This enables the tests in all browsers, it also attempts to improve the name of the test in BrowserStack.
I want to see the results from all the browsers, not just the first failure.
Also remove a redundant step
This prevents DoS via runaway regex evaluation. 100ms is more than generous for stripping non-alpahnumeric characters from a date.
On BrowserStack it seems my sessions are staying open until they time out. That's making the tests take way too long. This is an attempt to force them closed more quickly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is just one browser, with a first stab at the CI logic and test logic to do this. I've not tried any of this out locally yet but conceptually everything's here.