Adieu: Change stdin prompt behavior in tests #385
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec requires a prompt so stdin prompt should be True. This will also solve the long-standing issue of check50 reporting "Name: Name: ..." when the student fails to add a new line before printing the final message.
Instead they will now (correctly) see
```
:( input of "Liesl" yields "Adieu, adieu, to Liesl"
expected "Adieu, adieu, ...", not "Name: Adieu, a..."```
Note that the prompt remains False for the EOF check, otherwise it would consume the Name: on the final line and not alert to the error there.
Contributor
Author
|
@rongxin-liu I wonder if you might have a look at this? Thanks! |
Contributor
|
@curiouskiwi Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec requires a prompt so stdin prompt should be True. This will also solve the long-standing issue of check50 reporting
"Name: Name: ..."when the student fails to add a new line before printing the final message as illustrated in the demo. Instead they will now (correctly) seeNote that the prompt remains False for the EOF check, otherwise it would consume the Name: on the final line and not alert to the error there.