Skip to content

Comments

Consolidate and clean-up Fetch CSV file interactions#284

Merged
TimidRobot merged 3 commits intomainfrom
upgrade_csv
Feb 24, 2026
Merged

Consolidate and clean-up Fetch CSV file interactions#284
TimidRobot merged 3 commits intomainfrom
upgrade_csv

Conversation

@oree-xx
Copy link
Contributor

@oree-xx oree-xx commented Feb 9, 2026

Fixes

Description

  • Cleaned up repeated write_to_sv functions in fetch scripts.
  • Added rows_to_csv function to shared.py for appending data to csv file.
  • Removed the initialise_data function in arxiv fetch script
  • Changed the function name data_to_csv to dataframe_to_csv

Checklist

  • I have read and understood the Developer Certificate of Origin (DCO), below, which covers the contents of this pull request (PR).
  • My pull request doesn't include code or content generated with AI (also see Avoiding generative AI development tools — Creative Commons Open Source).
  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated unit tests and/or test scripts for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@oree-xx oree-xx requested review from a team as code owners February 9, 2026 13:00
@oree-xx oree-xx requested review from TimidRobot and possumbilities and removed request for a team February 9, 2026 13:00
@cc-open-source-bot cc-open-source-bot moved this to In review in TimidRobot Feb 9, 2026
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is looking great!

Please also update gcs_fetch.py to use shared.rows_to_csv() along with changes requested below.

@TimidRobot TimidRobot self-assigned this Feb 10, 2026
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small fixes required

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thank you!!

@TimidRobot TimidRobot merged commit 121c971 into main Feb 24, 2026
2 checks passed
@TimidRobot TimidRobot deleted the upgrade_csv branch February 24, 2026 19:07
@github-project-automation github-project-automation bot moved this from In review to Done in TimidRobot Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Consolidate and clean-up Fetch CSV file interactions

2 participants