[range.adaptors] Replace "In that case" with "If declared"#8534
Open
eisenwave wants to merge 1 commit intocplusplus:mainfrom
Open
[range.adaptors] Replace "In that case" with "If declared"#8534eisenwave wants to merge 1 commit intocplusplus:mainfrom
eisenwave wants to merge 1 commit intocplusplus:mainfrom
Conversation
Member
|
"If defined, [it] is defined a follows" is a bit repetitive. An alternative would be "X is not defined if V does not model C; otherwise it is defined as follows". I don't really like the double negative in that though. |
Member
Author
|
What about
The point of the fix is to disambiguate between whether "In that case" refers to only one of the conditions in the preceding sentence, or to all of them combined. If we refer to them in plural, that also works. |
jwakely
approved these changes
Nov 27, 2025
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
I don't love the phrasing, but it's an improvement.
Contributor
|
Needs some linebreaking/overfull-hbox fixes I think. |
eisenwave
force-pushed
the
clarify-in-that-case
branch
2 times, most recently
from
46964b6 to
e5d8272
Compare
Member
Author
|
Just needed a soft hyphen; please check again. |
jensmaurer
requested changes
Feb 25, 2026
eisenwave
force-pushed
the
clarify-in-that-case
branch
from
e5d8272 to
50176e1
Compare
jensmaurer
requested changes
Feb 26, 2026
eisenwave
force-pushed
the
clarify-in-that-case
branch
from
50176e1 to
680f448
Compare
eisenwave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5224.