Optionally allow unknown RW request content type#7293
Open
yeya24 wants to merge 3 commits intocortexproject:masterfrom
Open
Optionally allow unknown RW request content type#7293yeya24 wants to merge 3 commits intocortexproject:masterfrom
yeya24 wants to merge 3 commits intocortexproject:masterfrom
Conversation
… type and treat as remote write v1 Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
We had a recent change that returns 415 if the remote write content type is invalid #7238. This aligns with the standard Prometheus behavior as Prometheus doesn't allow non standard content type in the request as well.
However, this can be considered a breaking change in Cortex as existing remote write requests with different content type header can stop working and return 415. This can happen for users with custom remote write implementations.
To not break existing functionalities, add a flag to allow accepting unknown content type and fallback to Remote write v1.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]