Enable HATracker memberlist#7284
Open
SungJin1212 wants to merge 5 commits intocortexproject:masterfrom
Open
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
yeya24
reviewed
Feb 22, 2026
pkg/ha/ha_tracker.go
Outdated
| EnableStartupSync bool `yaml:"enable_startup_sync"` | ||
|
|
||
| KVStore kv.Config `yaml:"kvstore" doc:"description=Backend storage to use for the ring. Please be aware that memberlist is not supported by the HA tracker since gossip propagation is too slow for HA purposes."` | ||
| KVStore kv.Config `yaml:"kvstore" doc:"description=Backend storage to use for the ring. Please be aware that memberlist support in the HA tracker is currently experimental since gossip propagation is too slow for HA purposes."` |
Contributor
There was a problem hiding this comment.
We should reword it again. since gossip propagation is too slow for HA purposes is more for why we didn't allow memberlist before
|
|
||
| // Tracker kv store only supports consul and etcd. | ||
| storeAllowedList := []string{"consul", "etcd"} | ||
| if slices.Contains(storeAllowedList, cfg.KVStore.Store) { |
Contributor
There was a problem hiding this comment.
This PR should only just extend allow list to memberlist instead of allowing all stores
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Member
Author
|
@yeya24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables memberlist on HATracker.
It includes the implementations of a
mergeableinterface ofReplicaDesc.Which issue(s) this PR fixes:
Fixes #7220
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]