Bug/ruler use wrong alertmanager url#594
Merged
kd7lxl merged 4 commits intocortexproject:masterfrom Feb 24, 2026
Merged
Conversation
Collaborator
|
Looks alright can you sign the DCO? @amirulali |
kd7lxl
approved these changes
Feb 20, 2026
Collaborator
kd7lxl
left a comment
kd7lxl
left a comment
There was a problem hiding this comment.
LGTM
It will be mergeable once the DCO is signed.
Use the same method as alertmanager-headless-service to generate hostname Signed-off-by: Amirul Ali <amirul@rixv.net>
Signed-off-by: Amirul Ali <amirul@rixv.net>
amirulali
force-pushed
the
bug/ruler-use-wrong-alertmanager-url
branch
from
0c7dc79 to
720adc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Use the same method as alertmanager-headless-service to generate the hostname for alertmanager_url in ruler deployment.
Which issue(s) this PR fixes:
Fixes #593
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]