Add support for adding more console ports while VM is running #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtjhrc
requested review from
MatiasVara,
jakecorrenti,
slp and
tylerfanelli
as code owners
mtjhrc
changed the title
mtjhrc
force-pushed
the
dyn-port-console
branch
from
e566288 to
2be3425
Compare
mtjhrc
force-pushed
the
dyn-port-console
branch
6 times, most recently
from
1e4df25 to
482a48f
Compare
Introduce a static map to store references to running Vmm instances, enabling operations on VMs after they have been started. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Introduce krun_get_console_ready_fd() that returns an EventFd. The event is signaled when the console device is ready according to the guest. This allows applications to know when it's possible to start adding ports at runtime. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Add ConsoleController, an external handle that allows adding ports at runtime after the VM has started. It uses a channel to send new port descriptions to the running Console device. Add Console::with_controller factory method that returns both the Console and a ConsoleController. Update krun_add_console_port_tty and krun_add_console_port_inout to check RUNNING_CTX_MAP first, allowing ports to be added to a running VM. Introduce krun_console_reserve_ports() which pre-allocate virtqueues in the device for ports that will be added later at runtime. Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
dyn-port-console
branch
from
482a48f to
29bd1dd
Compare
Add dynamic console management that waits for the console device to become ready, then allows interactive addition of new console ports and pipe ports while the VM is running. Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
dyn-port-console
branch
from
29bd1dd to
1158760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.