Skip to content

Comments

feat: allow # in scope#148

Merged
thekaveman merged 1 commit intocompilerla:mainfrom
aeyoll:main
Feb 18, 2026
Merged

feat: allow # in scope#148
thekaveman merged 1 commit intocompilerla:mainfrom
aeyoll:main

Conversation

@aeyoll
Copy link
Contributor

@aeyoll aeyoll commented Feb 18, 2026

No description provided.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aeyoll!

Can I ask you to please also add one more test case for the # character to the regex test here:

assert regex.match("(some.thing)")

@aeyoll
Copy link
Contributor Author

aeyoll commented Feb 18, 2026

Thanks for the PR @aeyoll!

Can I ask you to please also add one more test case for the # character to the regex test here:

assert regex.match("(some.thing)")

Hello @thekaveman, I just added the test. Thx!

@aeyoll aeyoll requested a review from thekaveman February 18, 2026 17:12
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@thekaveman thekaveman merged commit 800557d into compilerla:main Feb 18, 2026
6 checks passed
@thekaveman
Copy link
Member

Thanks again @aeyoll.

This is now released in v4.4.0

Available on PyPI: https://pypi.org/project/conventional-pre-commit/4.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants