Add Qt 6.10 support (requires additional CorePrivate component)#95
Conversation
dzenanz
left a comment
There was a problem hiding this comment.
I ran into:
[10/23] Performing configure step for 'PythonQt'
loading initial cache file /home/local/KHQ/dzenan.zukic/Slicer-relQt6/CTK-build/PythonQt-cmake/tmp/PythonQt-cache-RelWithDebInfo.cmake
-- PythonQt: Required Qt components [Core;Widgets;Multimedia;PrintSupport;OpenGL;Network;MultimediaWidgets;UiTools]
-- Could NOT find Cups (missing: CUPS_LIBRARIES CUPS_INCLUDE_DIR)
-- Configuring done (0.2s)
CMake Error at CMakeLists.txt:348 (target_link_libraries):
Target "PythonQt" links to:
Qt6::CorePrivate
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
and this fixes it for me.
|
@sjh26 I don't have write access to this repository. |
4205de2 to
115dc3f
Compare
|
Workflow have been disabled as specific layout of the fork is not yet suitable, mainly because of the use of If the topic is forced push one more time, I except no workflows will be triggered. Before integrating this change, I suggest a PR is submitted upstream at https://github.com/MeVisLab/pythonqt and then cherry-picked following the established convention. See history of this branch for reference. In a nutshell commit. message should be prefixed with either |
Since upstream does not yet have CMake support, this doesn't apply in this particular case. |
115dc3f to
8da18a4
Compare
8da18a4 to
243ba16
Compare
We actually wanted to add cmake support upstream some time ago, but decided to wait for @jcfr (IIRC it was him who volunteered at the time) to back-merge it from this repo. |
|
Hi @mrbean-bremen , I want very much to make this happen 🚀 Having changed job +2 week or so ago, I am in the process of finalizing how/when I will work on it. In the meantime, thanks for the patience 🙏 |
Fixes #94
Hopefully this is the right branch ;)