Skip to content

Improve primary shell heuristics#44

Open
MatthijsBurgh wants to merge 2 commits intocolcon:masterfrom
MatthijsBurgh:improve_heuristics
Open

Improve primary shell heuristics#44
MatthijsBurgh wants to merge 2 commits intocolcon:masterfrom
MatthijsBurgh:improve_heuristics

Conversation

@MatthijsBurgh
Copy link

@MatthijsBurgh MatthijsBurgh commented Feb 12, 2026

Fixes #43

@MatthijsBurgh
Copy link
Author

@cottsay I went for the psutil solution. Please review

@MatthijsBurgh
Copy link
Author

@cottsay please review

@cottsay
Copy link
Member

cottsay commented Feb 24, 2026

please review

Has this been tested yet?

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (8f1fb0e) to head (892221b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
colcon_powershell/shell/powershell.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #44   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines          83      90    +7     
======================================
- Misses         83      90    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthijsBurgh
Copy link
Author

Yes, I have tested the logic in bash and in a powershell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Improve primary shell activation heuristics

3 participants