Skip to content

Conversation

@cottsay
Copy link
Member

@cottsay cottsay commented Jul 23, 2025

In Python 3.12 and newer, distutils is no longer part of the standard library. It appears that flake8 has been updated to regard it as such, so we need to update our import order.

Until the updated flake8 is ubiquitous, we'll need to specifically suppress the linting for those older versions.

In Python 3.12 and newer, distutils is no longer part of the standard
library. It appears that flake8 has been updated to regard it as such,
so we need to update our import order.

Until the updated flake8 is ubiquitous, we'll need to specifically
suppress the linting for those older versions.
@cottsay cottsay self-assigned this Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@2b6874c). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
colcon_core/distutils/commands/symlink_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #704   +/-   ##
=========================================
  Coverage          ?   87.04%           
=========================================
  Files             ?       69           
  Lines             ?     4077           
  Branches          ?      703           
=========================================
  Hits              ?     3549           
  Misses            ?      417           
  Partials          ?      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay cottsay merged commit 05462d2 into master Jul 23, 2025
40 checks passed
@cottsay cottsay deleted the cottsay/more-flake8 branch July 23, 2025 20:25
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ✅

@cottsay cottsay added this to the 0.19.1 milestone Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants