-
Notifications
You must be signed in to change notification settings - Fork 80
feat: Add configurable batch_size and max_workers to embed method #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fede-kamel
wants to merge
14
commits into
cohere-ai:main
Choose a base branch
from
fede-kamel:feat/configurable-embed-batch-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
18058d9
Add memory-efficient embed_stream method
6e974ed
feat: Add memory-efficient embed_stream method for processing large d…
998a514
feat: Add configurable batch_size and max_workers to embed method
8565fe3
test: Add comprehensive integration tests for embed_stream with OCI
fede-kamel 8ef4bdc
fix: Address Cursor Bugbot review findings in embed_stream
fede-kamel 2d337a3
fix: Address remaining Copilot review comments
fede-kamel 13b57e6
Merge branch 'main' into feat/configurable-embed-batch-size
fede-kamel c2c3f3e
fix: Address review feedback for configurable batch_size
fede-kamel 7c198ea
fix: Add warning when max_workers is used with AsyncClient
fede-kamel 73545e5
fix: Handle duplicate texts correctly in embed_stream
fede-kamel 792b57e
chore: Remove test files - insights moved to PR comments
fede-kamel d8bb1e7
fix: Address review feedback for embed_stream
fede-kamel a3c6200
fix: Address Cursor Bugbot review feedback
fede-kamel e0cdab3
fix: Handle empty string texts correctly in embed_stream
fede-kamel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ | |
| __pycache__/ | ||
| dist/ | ||
| poetry.toml | ||
| .venv/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.