Update backend to latest version & Improve documentation #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a volume to the Postgres service in docker-compose.yml - Replaced hardcoded values with environment variables in docker-compose.yml - Edited Makefile to include the .env file when starting Docker Compose - Renamed .env.development to .env.example and removed DATABASE_URL; now using environment variables to construct the Postgres connection URL - Updated documentation on how to set up the backend - Fixed yarn.lock (previous version was incompatible) - Added a NOTE.md to help with project structure - Increased SESSION_SECRET_MIN_LENGTH from 12 to 32 characters Note: The change to SESSION_SECRET_MIN_LENGTH could be considered a breaking change, depending on how long the production session secret is.
Author
|
I checked that login and the challenges themselves still work manually, the two tests still pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
Some important things changed, that could possibly break the deployment process:
.envno longer contains a database url, it now contains the individual variables for it to be crafted by the backendSESSION_SECRETis now required to be atleast 32 characters long, instead of 12package.jsonOther changes