ci: execute internal tests in workflows #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joka134 <27293650+joka134@users.noreply.github.com>
joka134
changed the title
Signed-off-by: joka134 <27293650+joka134@users.noreply.github.com>
Signed-off-by: joka134 <27293650+joka134@users.noreply.github.com>
siherrmann
approved these changes
Jan 12, 2026
Member
siherrmann
left a comment
siherrmann
left a comment
There was a problem hiding this comment.
Yeah, I think it's fine for now to just run all tests on both service build and cli build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-cliandmake test-serviceare not executing the tests in internal, which are only executed bymake test. Therefore these test were not executed in our workflows.This is the easy fix, which simply executes all tests on the build workflows. However, we could also decide to keep the separation and make sure internal is tested when running
make test-cli, which would make the Makefile a little bit more complex. I'm not sure if this is neeed at the moment, since running all tests takes only ~30s.https://app.clickup.com/t/869bc0grc