Merged
Conversation
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
Collaborator
Author
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
Collaborator
Author
|
Compared 30 screenshots: 30 matched. Benchmark Results
Detailed Performance Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Ports/iOSPort/nativeSources/IOSNative.mdescribing the black-overlay approach (used because static screenshots cannot be prevented), the choice of container view (prefer GL view controller then key window), the compile-time guard#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000(to avoid building against older SDKs), the runtime guard usingrespondsToSelector:@selector(isCaptured)and@available(iOS 11.0, *), and the notification observer onUIScreenCapturedDidChangeNotificationthat updates the overlay when capture starts/stops.Testing
Codex Task