Make delete confirmation more lightweight#1289
Conversation
This nulls out the `get_deleted_objects`, which is used by the django admin to display a list of objects, and more importantly related objects being deleted. As in particular with big owners/repos, actually building the list of all the related objects is unreasonably slow, so slow in fact that showing the confirmation dialog times out. To not block deletes of deeply nested object hierarchies, this will just return empty lists instead.
🚨 Sentry detected 4 potential issues in your recent changes 🚨Lower risk findings
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
- Coverage 96.35% 96.31% -0.04%
==========================================
Files 488 488
Lines 16919 16927 +8
==========================================
+ Hits 16302 16304 +2
- Misses 617 623 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This nulls out the
get_deleted_objects, which is used by the django admin to display a list of objects, and more importantly related objects being deleted.As in particular with big owners/repos, actually building the list of all the related objects is unreasonably slow, so slow in fact that showing the confirmation dialog times out.
To not block deletes of deeply nested object hierarchies, this will just return empty lists instead.
This should fix https://github.com/codecov/internal-issues/issues/1302