Fix type definitions for custom helpers with ESM default exports#5321
Merged
kobenguyent merged 6 commits into4.xfrom Nov 19, 2025
Merged
Fix type definitions for custom helpers with ESM default exports#5321kobenguyent merged 6 commits into4.xfrom
kobenguyent merged 6 commits into4.xfrom
Conversation
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix custom helper type definition for CodeceptJS 4.x
Fix type definitions for custom helpers with ESM default exports
Nov 19, 2025
Collaborator
kobenguyent
added a commit
that referenced
this pull request
Jan 7, 2026
* Initial plan * Initial investigation of custom helper type definition issue Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Fix custom helper type definitions for ESM default exports Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Remove generated steps.d.ts files from test fixtures * Final verification complete - all tests pass Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> * Remove generated steps.d.ts file from test fixtures Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation/Description of the PR
In CodeceptJS 4.x, custom helpers use ESM
export defaultsyntax. Thecodeceptjs defcommand generated incorrect TypeScript definitions that caused TypeScript to fail resolving helper methods on theIobject:The generated type referenced the module object instead of the exported class instance type.
Fix: Generate
InstanceType<typeof import(...).default>for.jsand.tshelper files to correctly resolve the class instance type from ESM default exports.Applicable helpers:
Applicable plugins: N/A
Type of change
Checklist:
npm run docs)npm run lint)npm test)Changes
lib/command/definitions.jsgetImportString()to check original file extension before generating type imports.js/.tsfiles: emitInstanceType<typeof import(...).default>Test coverage
.jsand.tscustom helpersExample
Custom helper with ESM syntax:
Generated type definition (after fix):
TypeScript now correctly resolves
I.openPage()with full IntelliSense.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
google.comnode /home/REDACTED/work/CodeceptJS/CodeceptJS/bin/codecept.js run --config /home/REDACTED/work/CodeceptJS/CodeceptJS/test/data/sandbox/codecept.bdd.js --grep @fail --steps(dns block)googlechromelabs.github.ionode install.mjs(dns block)https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.168/linux64/chrome-headless-shell-linux64.zipnode install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
codeceptjs defdoesn't work (Property does not exist on type 'I') #5318💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.