fix: add npm override for js-yaml to resolve security vulnerability#5308
Merged
kobenguyent merged 1 commit intocodeceptjs:3.xfrom Dec 3, 2025
Merged
Conversation
- Add js-yaml ^4.1.1 to package.json overrides - Fixes prototype pollution vulnerability (GHSA-mh29-5h37-fv8m) in js-yaml <4.1.1 - Forces all transitive dependencies to use the patched version - Resolves conflict between js-yaml 3.x (via @codeceptjs/detox-helper) and 4.x - All tests passing (unit and runner tests verified)
thomashohn
approved these changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a security fix for the js-yaml library by leveraging npm's overrides feature to force all transitive dependencies to use version ^4.1.1 or higher, which patches a prototype pollution vulnerability (GHSA-mh29-5h37-fv8m). The change follows the existing pattern in the codebase for managing security issues in indirect dependencies.
Key Changes
- Added js-yaml ^4.1.1 to the overrides section in package.json
- Resolves conflict between js-yaml 3.x (from @codeceptjs/detox-helper) and the patched 4.x version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)