fixed minor TS typing issues in class Result and output.result#5252
fixed minor TS typing issues in class Result and output.result#5252kobenguyent merged 3 commits intocodeceptjs:3.xfrom
Conversation
docs/plugins.md
Outdated
|
|
||
| ## reportData | ||
|
|
||
| TypeScript: Explicitly type reportData arrays as any\[] to avoid 'never' errors |
There was a problem hiding this comment.
@danielrentz I'm not sure if the \ here is intended?
There was a problem hiding this comment.
@kobenguyent As mentioned above... "Unrelated changes in plugins.md have been auto-generated by npm run docs."
No idea what to do about it. Even the git commit hooks manipulate these files, and confusingly in another way than the local build scripts. Will try to remove this change.
Another question... You changed the target branch from 3.x to 4.x a few weeks ago ... I did not notice this and thought I did that by mistake somehow, and therefore changed it back to 3.x. I remember that the PR did show dozens or hundrets of changed files when it has targeted 4.x. What is the desired way here? Is 3.x dead, and work continues in 4.x?
There was a problem hiding this comment.
Hi, great news! The 4.x version is now synced with 3.x. As you know, 4.x is an ESM migration, and I believe we’d like to merge into 4.x as much as possible, rather than keeping both 2 branches separate. Perhaps @DavertMik has a different perspective, and I’d love to hear your thoughts. Thanks!
Motivation/Description of the PR
Two small fixes for Typescript typings:
output.resultmisses a declaration for the optional parameter "failedHooks".class Resultmay contain numbers or strings. The exact type for a single failure report is[string, number, string, string, string]but that is not possible to declare with vanilla JSDoc. Added typedefFailureas string/number array, and replacedstring[]with the new type.Unrelated changes in
plugins.mdhave been auto-generated bynpm run docs.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)