sql: use ExecutorConfig in inspect logger
#160095
Open
+20
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
bghal
force-pushed
the
sql-resumer-friendly-logger
branch
from
a36b267 to
39c2224
Compare
bghal
changed the title
ExecutorConfig in inspect logger
Contributor
Author
|
bors r+ |
Contributor
|
Merge conflict. |
The inspect resumer needs to be able to log issues. The logger can use the `ExecutorConfig` embedded in the context without changing its behavior. Part of: cockroachdb#155472 Epic: CRDB-55075 Release note: None
bghal
force-pushed
the
sql-resumer-friendly-logger
branch
from
39c2224 to
de0e327
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
160095: sql: use `ExecutorConfig` in inspect logger r=bghal a=bghal The inspect resumer needs to be able to log issues. The logger can use the `ExecutorConfig` embedded in the context without changing its behavior. Part of: #155472 Epic: CRDB-55075 Release note: None Co-authored-by: Brendan Gerrity <brendan.gerrity@cockroachlabs.com>
Contributor
|
Build failed: |
Collaborator
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
160095: sql: use `ExecutorConfig` in inspect logger r=bghal a=bghal The inspect resumer needs to be able to log issues. The logger can use the `ExecutorConfig` embedded in the context without changing its behavior. Part of: #155472 Epic: CRDB-55075 Release note: None Co-authored-by: Brendan Gerrity <brendan.gerrity@cockroachlabs.com>
Contributor
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspect resumer needs to be able to log issues. The logger can use
the
ExecutorConfigembedded in the context without changing itsbehavior.
Part of: #155472
Epic: CRDB-55075
Release note: None