add support for auto detecting cluster domain#894
Open
meridional wants to merge 1 commit intocockroachdb:masterfrom
Open
add support for auto detecting cluster domain#894meridional wants to merge 1 commit intocockroachdb:masterfrom
meridional wants to merge 1 commit intocockroachdb:masterfrom
Conversation
meridional
force-pushed
the
auto-detect-domain-name
branch
3 times, most recently
from
59d0f4b to
66ec87d
Compare
|
when we can expect new release with last merges ? |
chrisseto
reviewed
Jul 12, 2022
Previously, the cluster domain is hardcoded to `cluster.local`. This PR adds support for auto detecting the domain by running a DNS query.
meridional
force-pushed
the
auto-detect-domain-name
branch
from
66ec87d to
54a8e46
Compare
chrisseto
approved these changes
Jul 18, 2022
Contributor
chrisseto
left a comment
chrisseto
left a comment
There was a problem hiding this comment.
LGTM!
You might have to rebase or regenerate something to get tests passing?
|
@chrisseto Can we please get this one retested/rebased please? Would be pretty nice to get this implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the cluster domain is hardcoded
to
cluster.local.This PR adds support for auto detecting
the domain by running a DNS query.
This addresses the issue #893.
Checklist