fix: record relative path when replace to local dir#139
Open
Duslia wants to merge 1 commit intocloudwego:mainfrom
Open
fix: record relative path when replace to local dir#139Duslia wants to merge 1 commit intocloudwego:mainfrom
Duslia wants to merge 1 commit intocloudwego:mainfrom
Conversation
Duslia
force-pushed
the
fix/replace_local_dir
branch
2 times, most recently
from
f7ff755 to
0d8e4e0
Compare
Duslia
force-pushed
the
fix/replace_local_dir
branch
from
0d8e4e0 to
5533b10
Compare
Collaborator
|
LGTM 人眼看了，regression 失败是正常的预期行为。 |
Hoblovski
approved these changes
Dec 29, 2025
Collaborator
Hoblovski
left a comment
Hoblovski
left a comment
There was a problem hiding this comment.
用户可能出现 replace 非本地的模块的边角情况吗？
可能的话加个 else { log.Error } 那报个错。
wzekin
reviewed
Dec 30, 2025
| } | ||
|
|
||
| if module.Replace != nil { | ||
| deps[module.Path] = module.Replace.Path + "@" + module.Replace.Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
当 replace 到了本地目录中的包时，修复 mod path 记录的是相对路径
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: