Skip to content

chore: Simplify code #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
just-boris wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Simplify code #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/components/extractor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export function extractExports(
const unknownExports: Array<string> = [];
for (const exportSymbol of exportSymbols) {
if (exportSymbol.name === 'default') {
validateComponentType(componentName, exportSymbol, checker);
validateComponentType(checker.getDeclaredTypeOfSymbol(exportSymbol), checker);
componentSymbol = exportSymbol;
} else if (exportSymbol.name === `${componentName}Props`) {
propsSymbol = exportSymbol;
Expand All @@ -167,18 +167,7 @@ export function extractExports(
return { componentSymbol, propsSymbol };
}

function validateComponentType(componentName: string, symbol: ts.Symbol, checker: ts.TypeChecker) {
const declaration = extractDeclaration(symbol);
let type: ts.Type;
if (ts.isExportAssignment(declaration)) {
// export default Something;
type = checker.getTypeAtLocation(declaration.expression);
} else if (ts.isFunctionDeclaration(declaration)) {
// export default function Something() {...}
type = checker.getTypeAtLocation(declaration);
} else {
throw new Error(`Unknown default export for ${componentName}`);
}
function validateComponentType(type: ts.Type, checker: ts.TypeChecker) {
if (
// React.forwardRef
type.getSymbol()?.name !== 'ForwardRefExoticComponent' &&
Expand Down
Loading