Skip to content

Conversation

@TrevorBurnham
Copy link
Contributor

@TrevorBurnham TrevorBurnham commented Dec 19, 2025

Description

Previously: #3856, #4065

Embarrassingly, that second PR was missing one of the two changes needed (as seen on the original branch), so it was insufficient to fix the glitch. This PR brings over that other change and adds test coverage for it.

Fixes #3848 cc @pan-kot

How has this been tested?

I've confirmed this fix locally by cherry-picking this SSR dev server commit and running it.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@TrevorBurnham TrevorBurnham requested a review from a team as a code owner December 19, 2025 01:32
@TrevorBurnham TrevorBurnham requested review from ernst-dev and removed request for a team December 19, 2025 01:32
@TrevorBurnham
Copy link
Contributor Author

FYI you can now validate these change by cherry-picking it onto this PR branch: #4127 Then visit http://localhost:8080/app-layout-toolbar/with-content-layout. You'll see that the sidebar toggle and content are still missing during the SSR render, but the breadcrumbs are correctly positioned.

@TrevorBurnham TrevorBurnham force-pushed the fix-applayout-toolbar-ssr-take-three branch from a2b61a7 to 13679db Compare December 29, 2025 15:13
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (4dcdb39) to head (13679db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4123   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         869      869           
  Lines       25473    25473           
  Branches     9208     9209    +1     
=======================================
  Hits        24745    24745           
+ Misses        722      681   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot added this pull request to the merge queue Dec 29, 2025
Merged via the queue into cloudscape-design:main with commit 27dbde0 Dec 29, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Visual glitches during SSR due to responsive design hooks

2 participants