feat: implement jump to page #4113
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngynmt
force-pushed
the
new-jump-to-page-branch
branch
from
4a1ead1 to
ab579b4
Compare
| }, | ||
| }; | ||
|
|
||
| const renderMainInput = () => ( |
Member
There was a problem hiding this comment.
const renderMainInput = <WithNativeAttributes....
| margin-block-start: calc(awsui.$space-scaled-xs * -1); | ||
| } | ||
|
|
||
| .inline-label { |
Member
There was a problem hiding this comment.
move this to mixin so it can be reused between select and input, probably move to https://github.com/cloudscape-design/components/blob/main/src/internal/styles/forms/mixins.scss
| }; | ||
|
|
||
| const defaultI18nStrings: Required<PaginationProps.I18nStrings> = { | ||
| jumpToPageLabel: 'Page', |
| loading?: boolean; | ||
| } | ||
|
|
||
| export interface JumpToPageRef { |
| type InternalPaginationProps = PaginationProps & InternalBaseComponentProps; | ||
| type InternalPaginationProps = PaginationProps & | ||
| InternalBaseComponentProps & { | ||
| jumpToPageRef?: React.Ref<PaginationProps.JumpToPageRef>; |
Member
There was a problem hiding this comment.
use forwardRef on the internal component as well, rather than manually adding it to the props
| function handleJumpToPageClick(requestedPageIndex: number) { | ||
| if (requestedPageIndex < 1) { | ||
| // Out of range lower bound - navigate to first page | ||
| setJumpToPageValue('1'); |
Member
There was a problem hiding this comment.
replace these 3 lines with handlePageClick(1)
| handlePageClick(requestedPageIndex); | ||
| } else { | ||
| // Out of range - set error and navigate to last page | ||
| setHasError(true); |
Member
There was a problem hiding this comment.
use handlePageClick here (with additional param for error state)
| tableComponentContext.paginationRef.current.openEnd = openEnd; | ||
| } | ||
|
|
||
| const renderJumpToPageButton = () => { |
Member
There was a problem hiding this comment.
plain value rather than function
| /** | ||
| * Returns the error popover for jump to page. | ||
| */ | ||
| findPopover(): PopoverWrapper | null { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current pagination component forces users to navigate sequentially through pages, creating poor user experience for large datasets. Users frequently need to access specific pages (e.g., jumping from page 1 to page 50) but must click through each intermediate page, leading to time-consuming navigation for large datasets. This change proposes additional options for user to navigate to a specific page.
How has this been tested?
Added examples of open-ended and closed-ended scenarios under tables pages
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.