Skip to content

Change the Image and Text Overlay Transformations From Pixels to Percentages #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aatanasov-cloudinary merged 6 commits into from
Jan 13, 2026
+56 −18
Merged

Change the Image and Text Overlay Transformations From Pixels to Percentages #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a81ef6
Move the image size to the end
aatanasovdev Jan 13, 2026
5cf7742
Change effect sizes to percentages
aatanasovdev Jan 13, 2026
124ba15
Merge branch 'fix/effects-order' of cloudinary_wordpress:cloudinary/c…
aatanasovdev Jan 13, 2026
d61206b
Revert class-api code
aatanasovdev Jan 13, 2026
89cbcbb
Add bundle files
aatanasovdev Jan 13, 2026
2fc1b8f
Ensure no changes part of the class-api file
aatanasovdev Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/cloudinary.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/asset-edit.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions src/css/components/_edit_overlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@
&-offset {
margin-bottom: 20px;

.suffixed {
width: 80%;
position: relative;
top: 5px;
}

.cld-input-text {
margin-bottom: 10px;
}
Expand Down
20 changes: 14 additions & 6 deletions src/js/asset-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const AssetEdit = {
this.imageOverlayMap = [
{ key: 'imageId', input: this.imageOverlayImageIdInput, defaultValue: '', event: 'input' },
{ key: 'publicId', input: this.imageOverlayPublicIdInput, defaultValue: '', event: 'input' },
{ key: 'size', input: this.imageOverlaySizeInput, defaultValue: 100, event: 'input' },
{ key: 'size', input: this.imageOverlaySizeInput, defaultValue: 20, event: 'input' },
{ key: 'opacity', input: this.imageOverlayOpacityInput, defaultValue: 20, event: 'input' },
{ key: 'position', input: this.imageOverlayPositionInput, defaultValue: '', event: 'change' },
{ key: 'xOffset', input: this.imageOverlayXOffsetInput, defaultValue: 0, event: 'input' },
Expand Down Expand Up @@ -376,6 +376,7 @@ const AssetEdit = {
this.textOverlayMap.forEach(({ input, defaultValue }) => {
if (input) {
input.value = defaultValue;
input.dispatchEvent(new Event('change'));
}
});

Expand All @@ -393,6 +394,7 @@ const AssetEdit = {
this.imageOverlayMap.forEach(({ input, defaultValue }) => {
if (input) {
input.value = defaultValue;
input.dispatchEvent(new Event('change'));
}
});

Expand All @@ -411,6 +413,10 @@ const AssetEdit = {
// Update preview to remove image overlay
this.preview.setSrc(this.buildSrc());
},
getFormattedPercentageValue( value ) {
const val = value / 100;
return val % 1 === 0 ? val.toFixed(1) : val;
},
buildPlacementQualifiers(positionInput, xOffsetInput, yOffsetInput) {
let placementQualifiers = [];

Expand All @@ -419,11 +425,11 @@ const AssetEdit = {
}

if (xOffsetInput?.value) {
placementQualifiers.push(`x_${xOffsetInput.value}`);
placementQualifiers.push(`x_${this.getFormattedPercentageValue(xOffsetInput.value)}`);
}

if (yOffsetInput?.value) {
placementQualifiers.push(`y_${yOffsetInput.value}`);
placementQualifiers.push(`y_${this.getFormattedPercentageValue(yOffsetInput.value)}`);
}

return placementQualifiers.length > 0 ? ',' + placementQualifiers.join(',') : '';
Expand All @@ -440,7 +446,7 @@ const AssetEdit = {
let transformations = [];

if (this.imageOverlaySizeInput?.value) {
transformations.push(`c_scale,w_${this.imageOverlaySizeInput.value}`);
transformations.push(`c_scale,w_${this.getFormattedPercentageValue(this.imageOverlaySizeInput.value)}`);
}

if (this.imageOverlayOpacityInput?.value) {
Expand All @@ -457,7 +463,7 @@ const AssetEdit = {
this.imageOverlayYOffsetInput
);

return `${imageLayerDefinition}/fl_layer_apply${placementString}`;
return `${imageLayerDefinition}/c_limit,w_1.0,fl_relative/fl_layer_apply${placementString}`;
},
buildTextOverlay() {
if (!this.textOverlayTextInput || !this.textOverlayTextInput.value.trim()) {
Expand Down Expand Up @@ -505,7 +511,7 @@ const AssetEdit = {
this.textOverlayYOffsetInput
);

return `${textLayerDefinition}/fl_layer_apply${placementString}`;
return `${textLayerDefinition}/c_limit,w_0.9,fl_relative/fl_layer_apply${placementString}`;
},
buildSrc() {
const transformations = this.transformationsInput.value;
Expand Down Expand Up @@ -591,11 +597,13 @@ const AssetEdit = {
map.forEach(({ key, input, defaultValue }) => {
if (input) {
input.value = (data && data[key] !== undefined) ? data[key] : defaultValue;
input.dispatchEvent(new Event('change'));

// Special handling for color input to initialize color picker
if (key === 'color' && input.value) {
jQuery(this.textOverlayColorInput).iris({ color: input.value });
}

if (key === 'imageId' && input.value) {
this.fetchImageById(input.value).then(attachment => {
AssetEdit.renderImageOverlay(attachment);
Expand Down
44 changes: 34 additions & 10 deletions ui-definitions/settings-pages.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@
array(
'type' => 'panel',
'collapsible' => 'open',
'title' => __( 'Text Overlay', 'cloudinary' ),
'title' => __( 'Text overlay', 'cloudinary' ),
array(
'type' => 'row',
array(
Expand Down Expand Up @@ -719,14 +719,24 @@
'title' => __( 'X Offset', 'cloudinary' ),
'default' => 0,
'slug' => 'text_overlay_x_offset',
'suffix' => 'px',
'suffix' => '%',
'attributes' => array(
'max' => 100,
'min' => -100,
'step' => 1,
),
),
array(
'type' => 'number',
'title' => __( 'Y Offset', 'cloudinary' ),
'default' => 0,
'slug' => 'text_overlay_y_offset',
'suffix' => 'px',
'suffix' => '%',
'attributes' => array(
'max' => 100,
'min' => -100,
'step' => 1,
),
),
),
),
Expand Down Expand Up @@ -764,7 +774,7 @@
array(
'type' => 'panel',
'collapsible' => 'open',
'title' => __( 'Image Overlay', 'cloudinary' ),
'title' => __( 'Image overlay', 'cloudinary' ),
array(
'type' => 'row',
array(
Expand Down Expand Up @@ -837,11 +847,13 @@
array(
'type' => 'text',
'title' => __( 'Size', 'cloudinary' ),
'default' => 100,
'default' => 20,
'slug' => 'image_overlay_size',
'suffix' => '@value %',
'attributes' => array(
'min' => 0,
'max' => 1000,
'min' => 1,
'max' => 100,
'step' => 1,
'type' => 'range',
'class' => array(
'edit-overlay-range-input',
Expand All @@ -853,9 +865,11 @@
'title' => __( 'Opacity', 'cloudinary' ),
'default' => 20,
'slug' => 'image_overlay_opacity',
'suffix' => '@value %',
'attributes' => array(
'min' => 0,
'min' => 1,
'max' => 100,
'step' => 1,
'type' => 'range',
'class' => array(
'edit-overlay-range-input',
Expand Down Expand Up @@ -898,14 +912,24 @@
'title' => __( 'X Offset', 'cloudinary' ),
'default' => 0,
'slug' => 'image_overlay_x_offset',
'suffix' => 'px',
'suffix' => '%',
'attributes' => array(
'max' => 100,
'min' => -100,
'step' => 1,
),
),
array(
'type' => 'number',
'title' => __( 'Y Offset', 'cloudinary' ),
'default' => 0,
'slug' => 'image_overlay_y_offset',
'suffix' => 'px',
'suffix' => '%',
'attributes' => array(
'max' => 100,
'min' => -100,
'step' => 1,
),
),
),
),
Expand Down