Closed
Conversation
🦋 Changeset detectedLatest commit: 3ef12c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anchpop
force-pushed
the
persist-room-name-for-alarm-cold-starts
branch
from
3bed22e to
bd1d3fd
Compare
anchpop
force-pushed
the
persist-room-name-for-alarm-cold-starts
branch
from
bd1d3fd to
3ef12c7
Compare
Collaborator
|
fixed in #337 cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32.
What:
This PR allows alarm cold starts to access the room name.
Why:
This removes a footgun (I hit this today)
How:
setName()writes the name to storage under__partyserver_name.#initialize()restores it beforeonStart()if the name isn't set. (IIUC, only alarms will hit this code path.)fetch()also validates that an incomingx-partykit-roomheader matches the stored name.Note:
I considered allowing
fetchto restore the room name from storage ifx-partykit-roomwas unset. But that would be a bigger deviation from the current behavior than necessary to close #32. If there any code for like moving DOs between rooms, this PR will obviously break that, but I couldn't find any such code.I couldn't find a way to make a durable object cold start in the tests, so I couldn't directly add a test for the intended functionality. However, I did add a test that the
__partyserver_namefield gets set, and that alarms work when that field gets set. The tests fail without this fix and pass with it.Disclaimer: I used LLM assistance to create this PR. I've reviewed the code of course. This PR description is written by me. (I might seem LLM-ey but I just talk like this)